Skip to content

Conversation

@fran6co
Copy link
Contributor

@fran6co fran6co commented Nov 27, 2025

Fixes #48105
Fixes #45820
Fixes #49750
Fixes #49197

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@fran6co fran6co force-pushed the fran/tracy branch 3 times, most recently from 6dd0343 to 11eda8a Compare November 27, 2025 17:58
@fran6co fran6co force-pushed the fran/tracy branch 5 times, most recently from d0414a5 to 6a94c0d Compare December 2, 2025 17:31
@fran6co
Copy link
Contributor Author

fran6co commented Dec 10, 2025

For some reason in windows it can't find the patch executable, is there a good way to deal with that?

@dg0yt
Copy link
Contributor

dg0yt commented Dec 10, 2025

For some reason in windows it can't find the patch executable, is there a good way to deal with that?

I would take this as a hint that it does something which it shouldn't do anyways:
What would it patch if not (sources of) vendored dependencies?

But the log show that it fails to find GIT_EXECUTABLE. This could be fixed easily. However it also shouldn't use git to download vendored dependencies...

@fran6co
Copy link
Contributor Author

fran6co commented Dec 10, 2025

It's getting imgui source code and patching it, vendoring imgui for this case I think it might be tricky as it's adding stuff to it

@dg0yt
Copy link
Contributor

dg0yt commented Dec 10, 2025

It's getting imgui source code and patching it, vendoring imgui for this case I think it might be tricky as it's adding stuff to it

I don't know if the vendored copy will be accepted.
But it might be necessary to at least pull download and patching out of the CMake project into the portfile.
Then the download could go through proper asset caching, and the vendored source would be obvious to reviewers. And you could add comments as needed.

@dg0yt
Copy link
Contributor

dg0yt commented Dec 10, 2025

A vendored imgui might be more acceptable if it is only used by executables, not libraries.

@fran6co
Copy link
Contributor Author

fran6co commented Dec 10, 2025

imgui is only used by the executables when using gui-tools, the lib itself doesn't depend on imgui

@fran6co
Copy link
Contributor Author

fran6co commented Dec 10, 2025

doing outside the cmake would require to always sync up on every tracy new version, if I could get windows to just find the patch binary for CPM to work then it would just work like the other platforms

@dg0yt
Copy link
Contributor

dg0yt commented Dec 10, 2025

doing outside the cmake would require to always sync up on every tracy new version, if I could get windows to just find the patch binary for CPM to work then it would just work like the other platforms

The portfile must do the downloads.

@simi
Copy link

simi commented Dec 15, 2025

Anything I can help with?

@fran6co
Copy link
Contributor Author

fran6co commented Dec 15, 2025

I don't have time to figure out the issue and/or move the downloading and patching of imgui to the portfile. The easy solution of making the windows builds to find the patch.exe seems not the accepted solution

@fran6co fran6co force-pushed the fran/tracy branch 5 times, most recently from af49cf9 to 3e567f6 Compare February 4, 2026 11:23
@fran6co fran6co marked this pull request as ready for review February 4, 2026 11:25
@fran6co fran6co force-pushed the fran/tracy branch 4 times, most recently from 5fc69f5 to c9cabc2 Compare February 4, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tracy] update to 0.13.1 [tracy] update to 0.13.1

3 participants