-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[tracy] update to 0.13 #48506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[tracy] update to 0.13 #48506
Conversation
6dd0343 to
11eda8a
Compare
d0414a5 to
6a94c0d
Compare
|
For some reason in windows it can't find the patch executable, is there a good way to deal with that? |
I would take this as a hint that it does something which it shouldn't do anyways: But the log show that it fails to find |
|
It's getting imgui source code and patching it, vendoring imgui for this case I think it might be tricky as it's adding stuff to it |
I don't know if the vendored copy will be accepted. |
|
A vendored imgui might be more acceptable if it is only used by executables, not libraries. |
|
imgui is only used by the executables when using gui-tools, the lib itself doesn't depend on imgui |
|
doing outside the cmake would require to always sync up on every tracy new version, if I could get windows to just find the patch binary for CPM to work then it would just work like the other platforms |
The portfile must do the downloads. |
|
Anything I can help with? |
|
I don't have time to figure out the issue and/or move the downloading and patching of imgui to the portfile. The easy solution of making the windows builds to find the patch.exe seems not the accepted solution |
af49cf9 to
3e567f6
Compare
5fc69f5 to
c9cabc2
Compare
Fixes #48105
Fixes #45820
Fixes #49750
Fixes #49197
./vcpkg x-add-version --alland committing the result.