-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[xdigest] new port #49708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rinrab
wants to merge
4
commits into
microsoft:master
Choose a base branch
from
rinrab:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−0
Draft
[xdigest] new port #49708
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO rinrab/xdigest | ||
| REF "${VERSION}" | ||
| SHA512 9bb3ceaca9a3cf35b5dd562589158dc50ad3692c3d17d4b39e1f4a36a00861e30913de5ae3052836deb3ef76a45ad69c7822e2fb14a27c6d73dfcd6115a76d15 | ||
| HEAD_REF trunk | ||
| ) | ||
|
|
||
| vcpkg_check_features( | ||
| OUT_FEATURE_OPTIONS FEATURE_OPTIONS | ||
| FEATURES | ||
| asm USE_ASM | ||
| ) | ||
|
|
||
| if (VCPKG_TARGET_IS_WINDOWS AND USE_ASM) | ||
| vcpkg_find_acquire_program(NASM) | ||
| list(APPEND OPTIONS "-DCMAKE_ASM_NASM_COMPILER=${NASM}") | ||
| endif() | ||
|
|
||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -DENABLE_TESTS=OFF | ||
| ${FEATURE_OPTIONS} | ||
| ${OPTIONS} | ||
| ) | ||
| vcpkg_cmake_install() | ||
| vcpkg_copy_pdbs() | ||
| vcpkg_fixup_pkgconfig() | ||
| vcpkg_cmake_config_fixup(CONFIG_PATH "lib/cmake/xdigest") | ||
|
|
||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | ||
|
|
||
| vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "name": "xdigest", | ||
| "version": "0.3.0", | ||
| "description": "Extremely fast digest algorithms packaged into a lightweight library.", | ||
| "homepage": "https://github.com/rinrab/xdigest", | ||
| "license": "Apache-2.0", | ||
| "dependencies": [ | ||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| }, | ||
| { | ||
| "name": "vcpkg-cmake-config", | ||
| "host": true | ||
| } | ||
| ], | ||
| "default-features": [ | ||
| "asm" | ||
| ], | ||
| "features": { | ||
| "asm": { | ||
| "description": "Assembly-backed implementation for maximum performance.", | ||
| "supports": "!(windows & arm) & !android" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "versions": [ | ||
| { | ||
| "git-tree": "d57a52c9ad30ded8e6a64bcb276b6ca07ef8645a", | ||
| "version": "0.3.0", | ||
| "port-version": 0 | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this shouldn't be a feature; if anything it would be something someone may want to force off, and that's not what features are for. (In particular, in vcpkg's model it is always assumed that turning on a feature is 'safe')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, according to vcpkg's model, this should not be in the port at all? And it should decide whether to build assemblies or not on its own? If feature in vcpkg suppose to enable some specific optional modules let's say, that makes sense.
Also, in this case the feature should actually be safe to use as it's the core funtionality of the library.