Try cloning the env object since it has properties that may not get shallow copied#1359
Open
Try cloning the env object since it has properties that may not get shallow copied#1359
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes failing nightly CRUD tests by ensuring the Azure subscription environment object is cloned into the test action context so required environment properties (e.g., resourceManagerEndpointUrl) are present when used by Azure client code.
Changes:
- Replace shallow spread-based context construction with an explicit
environment: structuredClone(...)assignment. - Ensure the
environmentobject is copied in a way that preserves properties that may not survive shallow copying.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were failing because the azureClient needed to access
environment.resourceManagerEndpointUrl. So I deep copied the environment object into the context.