appservice: Upgrade appservice sdk and bump package version#2184
Merged
MicroFish91 merged 13 commits intomainfrom Feb 6, 2026
Merged
appservice: Upgrade appservice sdk and bump package version#2184MicroFish91 merged 13 commits intomainfrom
appservice sdk and bump package version#2184MicroFish91 merged 13 commits intomainfrom
Conversation
MicroFish91
changed the title
appservice sdk and bump package versionappservice sdk and bump package version
bwateratmsft
reviewed
Feb 6, 2026
bwateratmsft
reviewed
Feb 6, 2026
bwateratmsft
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm upgrading the
appservicedependency by 3 major versions, so also bumped the major version for the release.Note: I could not figure out why the typescript build was failing for CJS but not ESM without the typecast. It seems it is not recognizing that
WebSiteManagementClientextends the requiredServiceClient. It thinks it's a differentServiceClientdefinition. When I step into each type, they both point to the same definitions. I thought initially it might be becausecreateAzureClientwas pointing to a different core client type from another version, but even after upgrading the azure package to the same core client version that the SDK uses internally, the compile error still seemed to persist.I'm not thrilled with an unknown typecast as the solution, but I'm not sure what a better solution would be. It seems to work okay extension-side AFAICT (mostly tested using Azure Functions extension).
I let Copilot churn on it for a while and it seems to think this is a ESM/CJS module resolution quirk; I'm still not confident on the exact reasoning though.