This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Removes the custom viewport if you are not in a GitHub repo #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmarti
suggested changes
Oct 24, 2017
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please see my review comments.
| "id": "githubIssuesPrs", | ||
| "name": "GitHub Issues and PRs" | ||
| "name": "GitHub Issues and PRs", | ||
| "when": "is-running-a-github-repo" |
Contributor
There was a problem hiding this comment.
This appears to prevent the extension from activating with the "onView:githubIssuesPrs" event (see further up in this file). Activating on "*" should be good enough for now.
| } | ||
|
|
||
| private async fetchChildren(element?: TreeItem): Promise<TreeItem[]> { | ||
| const remotes = await this.getGitHubRemotes(); |
Contributor
There was a problem hiding this comment.
We seem to only get here when the view is already activated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the extension viewport by default and then adds the viewport when it's been confirmed that you're in a GitHub repo.