Skip to content

Conversation

@allancascante
Copy link
Contributor

@allancascante allancascante commented Nov 20, 2025

Description

This PR refactors the task completion notification system to eliminate duplicate notifications for DacFx operations (Export BACPAC, Extract DACPAC, Import BACPAC, Deploy DACPAC) and provides a generic, configurable solution for custom task completion handlers, as reported in this bug.

Problem
Previously, DacFx operations showed two notifications:

A custom notification with action button from dacpacDialogWebviewController
A generic completion notification from sqlTasksService

Solution

Centralized all task completion notification logic in sqlTasksService with a configurable handler registration system.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5289 KB 5289 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )
data-workspace VSIX null KB 542 KB ⚪ 542 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 98.61111% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.60%. Comparing base (24d2641) to head (da1764e).

Files with missing lines Patch % Lines
extensions/mssql/src/controllers/mainController.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20651      +/-   ##
==========================================
+ Coverage   66.33%   66.60%   +0.27%     
==========================================
  Files         210      210              
  Lines       20235    20272      +37     
  Branches     2634     2638       +4     
==========================================
+ Hits        13423    13503      +80     
+ Misses       6716     6671      -45     
- Partials       96       98       +2     
Files with missing lines Coverage Δ
extensions/mssql/src/constants/constants.ts 100.00% <100.00%> (ø)
...l/src/controllers/dacpacDialogWebviewController.ts 92.16% <ø> (+0.64%) ⬆️
extensions/mssql/src/services/dacFxService.ts 51.38% <100.00%> (+46.12%) ⬆️
extensions/mssql/src/services/sqlTasksService.ts 85.04% <100.00%> (+48.57%) ⬆️
extensions/mssql/src/controllers/mainController.ts 17.27% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allancascante allancascante merged commit 760a87b into main Dec 24, 2025
3 checks passed
@allancascante allancascante deleted the dev/allancascante/notification_fixes branch December 24, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Data-tier Application dialog has duplicate notifications

5 participants