-
Notifications
You must be signed in to change notification settings - Fork 55
Add CLI flags for explicit OCI authentication credentials #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: copilot/add-oci-authentication-support
Are you sure you want to change the base?
Changes from all commits
db34cb7
d748da6
2af425d
a5195e1
65fae81
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -153,11 +153,18 @@ pub trait Loadable: Sized { | |||||||||||
| const RESOURCE_TYPE: &'static str; | ||||||||||||
|
|
||||||||||||
| async fn from_local_file(path: &Path) -> Result<DownloadedResource>; | ||||||||||||
|
||||||||||||
| async fn from_local_file(path: &Path) -> Result<DownloadedResource>; | |
| async fn from_local_file(path: &Path) -> Result<DownloadedResource>; | |
| /// Retained for backward compatibility with existing consumers of the Loadable trait. | |
| /// The preferred method is `from_oci_reference_with_progress_and_credentials`. | |
| /// The `#[allow(dead_code)]` attribute suppresses warnings since this method may not be used internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the loader.rs case, this private method now has
#[allow(dead_code)]because it's been replaced byresolve_component_resource_with_credentials. Since this appears to be a private method (not pub), consider whether it should be removed entirely rather than kept with the dead_code attribute. If it's intentionally kept for potential future use or backward compatibility, add a comment explaining why.