fix: do not sanitize `CARGO_HOME` & `RUSTUP_HOME` #609

gurry · 2026-02-10T06:44:19Z

Fixes #606

Earlier we removed all the rustup and cargo related env vars before invoking cargo wdk build in tests to prevent them from influencing latter's behaviour. However, it caused some tests to fail in situations where rustup or cargo are installed at non-standard paths. So in this PR we skip removing CARGO_HOME and RUSTUP_HOME.

Copilot

Pull request overview

Adjusts the cargo-wdk integration test harness to avoid stripping rustup/cargo-related environment variables, fixing local test failures when rustup is installed in a non-default location (Issue #606).

Changes:

Replace broad env-var sanitization (CARGO*/RUST*) with targeted PATH sanitization.
Stop removing .rustup/toolchain-related entries from PATH.
Rename sanitize_env_vars to sanitize_path and update its intent/docs accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/cargo-wdk/tests/test_utils/mod.rs

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/cargo-wdk/src/cli.rs

crates/cargo-wdk/tests/build_command_test.rs

crates/cargo-wdk/tests/test_utils/mod.rs

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/test.yaml

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/cargo-wdk/tests/build_command_test.rs

crates/cargo-wdk/tests/test_utils/mod.rs

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/cargo-wdk/src/cli.rs

crates/cargo-wdk/tests/build_command_test.rs

crates/cargo-wdk/tests/test_utils/mod.rs

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/cargo-wdk/tests/test_utils/mod.rs

Removing these variables may cause some tests to fail when `rustup` or `cargo` is installed at non-standard paths (issue microsoft#606).

codecov-commenter · 2026-02-11T10:05:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.41%. Comparing base (4895c2d) to head (355c931).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   77.41%   77.41%           
=======================================
  Files          24       24           
  Lines        4853     4853           
  Branches     4853     4853           
=======================================
  Hits         3757     3757           
  Misses        979      979           
  Partials      117      117

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/cargo-wdk/tests/test_utils/mod.rs

gurry requested review from a team and Copilot February 10, 2026 06:44

Copilot started reviewing on behalf of gurry February 10, 2026 06:45 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

crates/cargo-wdk/tests/test_utils/mod.rs Outdated Show resolved Hide resolved

gurry marked this pull request as draft February 10, 2026 10:18

Copilot AI review requested due to automatic review settings February 10, 2026 10:28

gurry force-pushed the 606-custom-rustup-location-issue branch from 48d1346 to 9fc7af5 Compare February 10, 2026 10:28

Copilot started reviewing on behalf of gurry February 10, 2026 10:29 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

crates/cargo-wdk/src/cli.rs Outdated Show resolved Hide resolved

crates/cargo-wdk/tests/build_command_test.rs Outdated Show resolved Hide resolved

crates/cargo-wdk/tests/test_utils/mod.rs Show resolved Hide resolved

Copilot AI review requested due to automatic review settings February 10, 2026 11:08

Copilot started reviewing on behalf of gurry February 10, 2026 11:09 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

.github/workflows/test.yaml Outdated Show resolved Hide resolved

.github/workflows/test.yaml Outdated Show resolved Hide resolved

.github/workflows/test.yaml Show resolved Hide resolved

gurry force-pushed the 606-custom-rustup-location-issue branch from d25a3b0 to c9b6ce9 Compare February 10, 2026 11:15

Copilot AI review requested due to automatic review settings February 10, 2026 11:35

Copilot started reviewing on behalf of gurry February 10, 2026 11:35 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

crates/cargo-wdk/tests/build_command_test.rs Outdated Show resolved Hide resolved

crates/cargo-wdk/tests/test_utils/mod.rs Outdated Show resolved Hide resolved

gurry force-pushed the 606-custom-rustup-location-issue branch from 4f55db9 to 492b728 Compare February 10, 2026 12:45

Copilot AI review requested due to automatic review settings February 10, 2026 13:04

Copilot started reviewing on behalf of gurry February 10, 2026 13:05 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

crates/cargo-wdk/src/cli.rs Outdated Show resolved Hide resolved

crates/cargo-wdk/tests/build_command_test.rs Outdated Show resolved Hide resolved

crates/cargo-wdk/tests/test_utils/mod.rs Outdated Show resolved Hide resolved

gurry force-pushed the 606-custom-rustup-location-issue branch from c18fb46 to 9e6861c Compare February 11, 2026 08:32

Copilot AI review requested due to automatic review settings February 11, 2026 09:21

gurry force-pushed the 606-custom-rustup-location-issue branch from 9e6861c to b8b5677 Compare February 11, 2026 09:21

Copilot started reviewing on behalf of gurry February 11, 2026 09:22 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

crates/cargo-wdk/tests/test_utils/mod.rs Outdated Show resolved Hide resolved

crates/cargo-wdk/tests/test_utils/mod.rs Show resolved Hide resolved

fix: do not sanitize CARGO_HOME and RUSTUP_HOME

355c931

Removing these variables may cause some tests to fail when `rustup` or `cargo` is installed at non-standard paths (issue microsoft#606).

gurry force-pushed the 606-custom-rustup-location-issue branch from b8b5677 to 355c931 Compare February 11, 2026 09:38

gurry changed the title ~~fix: do not sanitize rustup & cargo envs~~ fix: do not sanitize CARGO_HOME & RUSTUP_HOME Feb 11, 2026

gurry marked this pull request as ready for review February 11, 2026 11:06

Copilot AI review requested due to automatic review settings February 11, 2026 11:06

Copilot started reviewing on behalf of gurry February 11, 2026 11:07 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

crates/cargo-wdk/tests/test_utils/mod.rs Show resolved Hide resolved

crates/cargo-wdk/tests/test_utils/mod.rs Show resolved Hide resolved

gurry enabled auto-merge February 12, 2026 05:41

fix: do not sanitize CARGO_HOME & RUSTUP_HOME #609

Are you sure you want to change the base?

fix: do not sanitize CARGO_HOME & RUSTUP_HOME #609

Uh oh!

Conversation

gurry commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: do not sanitize `CARGO_HOME` & `RUSTUP_HOME` #609

fix: do not sanitize `CARGO_HOME` & `RUSTUP_HOME` #609

gurry commented Feb 10, 2026 •

edited

Loading

codecov-commenter commented Feb 11, 2026 •

edited

Loading