Skip to content

Reinitialize mixer after StopTransport #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrayxRulez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reinitialize mixer after StopTransport #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions patches_for_WebRTC_org/m84/src/modules/audio_device/win/audio_device_core_win.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,8 @@ struct AudioDeviceHelper : public DeviceHelper<DEVICE_CLASS> {
CloseHandle(_hThread);
_hThread = nullptr;
_transporting = false;
_transportInitialized = false;
Copy link

@jlautman jlautman Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be set to false on line 630 to avoid setting the same value in two places? Or would that introduce a potential race condition?

Copy link
Contributor Author

@FrayxRulez FrayxRulez Mar 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that there's the risk of a race condition, as if you see _transporting was set to false in both places even before my change.

_mixerInitialized = false;
return -1;
}

Expand All @@ -647,6 +649,8 @@ struct AudioDeviceHelper : public DeviceHelper<DEVICE_CLASS> {
ResetEvent(_hShutdownEvent);

_transporting = false;
_transportInitialized = false;
_mixerInitialized = false;

CloseHandle(_hThread);
_hThread = nullptr;
Expand Down