Skip to content

Conversation

@sandeepjha000
Copy link
Collaborator

adding test 35037

@sandeepjha000 sandeepjha000 self-assigned this Feb 2, 2026
@sandeepjha000 sandeepjha000 added the ready for review PR is ready for review and merging label Feb 2, 2026
Copy link
Collaborator

@merill merill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepjha000 if there is an error getting the logging status, we should flag the test as skipped and provide the reason.

Right now, it doesn't get a pass or fail based on the logic.

@sandeepjha000
Copy link
Collaborator Author

@sandeepjha000 if there is an error getting the logging status, we should flag the test as skipped and provide the reason.

Right now, it doesn't get a pass or fail based on the logic.
@merill - The exchange commands can mostly fail due to permissions issue or when not connected to exchange online.
Currently we have only one skip reason NotConnectedExchange
To skip when we have access issues, shall I add a new reason NoExchangeAccess, we currenly have similar skip reason for Azure NoAzureAccess

@sandeepjha000 sandeepjha000 requested a review from merill February 3, 2026 06:28
@alexandair
Copy link
Collaborator

Passed my review. It's expected that "skipped reason" is fixed in a bulk change in the near future.

LGTM

/cc @merill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review PR is ready for review and merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants