Skip to content

Conversation

@aahmed-spec
Copy link
Collaborator

No description provided.

@aahmed-spec aahmed-spec changed the title Data - 35035 - Sensitivity Label Policy Rules and Scope Data - 35035 - Named Entity SITs Usage in Auto-Labeling and DLP Policies Feb 4, 2026
@aahmed-spec aahmed-spec marked this pull request as ready for review February 4, 2026 11:55
@alexandair alexandair requested a review from Copilot February 4, 2026 12:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two new assessment tests for Microsoft 365 Data protection capabilities focused on advanced classification and sensitivity label features.

Changes:

  • Test-Assessment.35035: Validates Named Entity SITs usage in Auto-Labeling and DLP policies
  • Test-Assessment.35012: Validates container labels configuration for Teams, Groups, and Sites

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Test-Assessment.35035.ps1 Implements test to evaluate Named Entity SIT deployment in auto-labeling and DLP rules with ID-based matching against the EntityMatch classifier
Test-Assessment.35035.md Provides documentation and remediation guidance for deploying Named Entity SITs via DLP or auto-labeling policies
Test-Assessment.35012.ps1 Implements test to detect container labels with both protectgroup and protectsite actions for workspace-level security
Test-Assessment.35012.md Provides documentation and remediation steps for configuring container labels for collaboration workspaces

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ZtTest(
Category = 'Sensitivity Labels Configuration',
ImplementationCost = 'Medium',
MinimumLicense = 'Microsoft_365_E5',
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MinimumLicense value 'Microsoft_365_E5' uses underscores instead of spaces, which is inconsistent with the license naming convention used throughout the codebase. Other similar tests use 'Microsoft 365 E5' with spaces (as seen in Test-Assessment.35032.ps1 line 26 and other files). This inconsistency could cause issues with license checking logic.

Suggested change
MinimumLicense = 'Microsoft_365_E5',
MinimumLicense = 'Microsoft 365 E5',

Copilot uses AI. Check for mistakes.
Pillar = 'Data',
RiskLevel = 'High',
SfiPillar = 'Protect tenants and production systems',
TenantType = ('Workforce'),
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TenantType value includes parentheses around a single value 'Workforce', which is inconsistent with the pattern used when there's only one tenant type. When a single value is specified, it should either be a single string without parentheses (as in 'TenantType = Workforce') or use the array syntax consistently. Looking at Test-Assessment.35012.ps1 line 26, it uses 'TenantType = 'Workforce'' without parentheses for a single value.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants