Format codebase and add support for multi-tenancy ..#7
Open
dlobo wants to merge 15 commits intomidas:masterfrom
Open
Format codebase and add support for multi-tenancy ..#7dlobo wants to merge 15 commits intomidas:masterfrom
dlobo wants to merge 15 commits intomidas:masterfrom
Conversation
Contributor
Author
|
wondering if you have any thoughts or comments on these changes? |
Contributor
Author
|
Can you let me know either way. Working towards another version of the package that we'd like to publish on hexdocs.pm lobo |
sending opts as well
When calling a function, use paranthesis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to fork the repo again to add one more feature. We needed support to run the same migration again for a different tenant. This is especially important in the initial db seeding phase (not so sure if needed for later migrations, but we'll cross that bridge when we get there). Added a tenant column to the schema_seeds table to make this possible
also formatted the code using the built in formatter
if you are open to this being merged, I'll take a closer look at the PR, delete most of the commented code and do some more cleanup