Upstream node-0.20.0-rc.5 changes #537
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first patch didn't contain all of the change. --------- Co-authored-by: Justin Frevert <justinfrevert@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
rc4 - all aiken contracts
* revert to previous postgres connection config * whoops * change file
* fix: remove check for spends in gov utxo query The query will get the latest gov utxo at the time of block query The previous query checked if that utxo had been spent, including in blocks that are not yet stable (vulnerability) * chore: add pr link to change file * fix(e2e): wait for registration observation before minting in tests Fix race condition in cNIGHT E2E tests where tokens were minted before the Midnight node had observed and processed the registration. This caused the UtxoOwners storage to not be populated because handle_create couldn't find the mapping in Mappings storage. Added subscribe_to_cnight_observation_events calls after registrations to ensure the mapping is in storage before minting tokens. Tests fixed: - cnight_produces_dust - deregister_first_mapping - deregister_with_valid_cnight_utxo - produce_dust_from_tokens_owned_before_registration - register_twice_with_same_cardano_address - spend_cnight_producing_dust - stop_dust_producing_after_deregistration_and_rotation * Revert "fix(e2e): wait for registration observation before minting in tests" This reverts commit 9fd298d. The test failures are not caused by a race condition but by incorrect cnight_asset_name configuration. * fix: reset cnight_asset_name to empty in qanet config The cnight_asset_name was incorrectly set to "NIGHT" which is the mainnet value. For testnet/qanet, this should be empty ("") to match what the local-env midnight-setup produces. This was causing the local-env E2E tests to fail because the minted cNIGHT tokens had no asset name but the node was configured to look for tokens with asset name "NIGHT". * fix: doc * fix: docs 2 * fix: set token asset back to empty * fix: remove haskell contracts usage from local-env Refs: PM-21472 * chain spec regeneration * chore: rebuild chainspecs with empty cnight asset name Rebuilt chainspecs for node-dev-01, preprod, preview, and qanet networks. * remove qanet addresses --------- Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Co-authored-by: Mike Clay <mike.clay@shielded.io> Co-authored-by: NachoPal <ignacio.palacios.santos@gmail.com> Co-authored-by: Radosław Sporny <404@rspo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated Pull Request
Note: Workflow runs will not be triggered by this automated PR
To trigger them, manually open and close the pull request.
This is a "feature" of GitHub Actions, which does not trigger workflows on automated PRs.
Updated
mainbranch with changes from the releaseReplaced 'changes/' directory with an empty template
Archived current changes to '.changes_archive/node-0.20.0-rc.5'