Open
Conversation
|
Hi, |
Author
|
Thanks @yuki-koyama! So only including the header file (and not deleting the copyright lines which are part of the header) is ok? |
|
In my understanding, yes |
Owner
|
Thanks for the PR. I like the idea of this but I don't want to just swap out the current colormap with a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the viridis colormap, and includes support for many other colormaps. I'm not totally sure if just including the header of https://github.com/yuki-koyama/tinycolormap is allowed license-wise, perhaps @yuki-koyama can comment. I think setting up cmake to use submodules just for one file be a bit of an overkill.