Skip to content

Bugfix/xss non get #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukestokes wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/xss non get #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ea0d6
Merge pull request #1 from mikekelly/master
lukestokes Nov 13, 2017
44be2be
Fixes an XSS concern with non-get uris like so:
lukestokes Nov 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions browser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,10 @@ <h3>Expand URI Template</h3>
<h3>Make a non-GET request</h3>
</div>

<form class="non-safe" action="<%= href %>">
<form class="non-safe" action="<%= _.escape(href) %>">
<div class="modal-body">
<p>Target URI</p>
<input name="url" type="text" class="url" value="<%= href %>" />
<input name="url" type="text" class="url" value="<%= _.escape(href) %>" />
<p>Method:</p>
<input name="method" type="text" class="method" value="POST" />
<p>Headers:</p>
Expand Down