[DRAFT] Upgrade c-blosc2 to 2.15.2#33
Closed
musicinmybrain wants to merge 2 commits intomilesgranger:mainfrom
Closed
[DRAFT] Upgrade c-blosc2 to 2.15.2#33musicinmybrain wants to merge 2 commits intomilesgranger:mainfrom
musicinmybrain wants to merge 2 commits intomilesgranger:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The good news is that I think that I figured out the correct procedure to update the bundled C blosc2 library and re-generate the bindings, and that
cargo test --workspacepasses.The bad news is that I opened this PR is in service of trying to reproduce a segfault in the
libcramjamtests that started happening when Fedora’sblosc2package was updated from 2.15.1 to 2.15.2 – so I wouldn’t recommend merging this just yet. I’ll open an issue on https://github.com/cramjam/libcramjam as soon as I’ve pulled together all the details.