Conversation
Updated the JULES_SYSTEM_PROMPT in src/mycoder/triage_agent.py to match the user's latest specification, specifically clarifying that the output target is a file. Maintained strict JSON output constraints and safety adaptations (stripping shell command generation instructions) as per system memory and agent guidelines. Verified with unit tests in tests/unit/test_triage_agent.py. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🤖 Hi @milhy545, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Summary of ChangesHello @milhy545, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the reliability and clarity of the Jules triage agent's system prompt. The changes ensure that the agent consistently produces strict JSON output by refining instructions, adapting variable formats, and removing ambiguous guidance, ultimately improving the agent's interaction and parsing success. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the system prompt for the Jules triage agent and adds a corresponding changelog entry. While the changelog update is fine, the modification to the system prompt in src/mycoder/triage_agent.py introduces an inconsistency. The prompt now directs the LLM to write to an "output file," but the script's implementation writes the result to standard output. This discrepancy can be confusing and I've recommended reverting that specific text to be more general and accurate.
| ## Output Specification | ||
|
|
||
| Write a JSON array to the output. Format: | ||
| Write a JSON array to the output file. Format: |
There was a problem hiding this comment.
The prompt now instructs the LLM to "Write a JSON array to the output file." However, the script's main function processes the LLM's response and prints it to standard output (stdout), not a file. This creates a contradiction between the instruction and the actual behavior, which could confuse the LLM. The previous wording, "Write a JSON array to the output.", was more accurate as "output" can generally refer to the generation result.
| Write a JSON array to the output file. Format: | |
| Write a JSON array to the output. Format: |
Updated
src/mycoder/triage_agent.pyto refine the system prompt for the Jules triage agent.Changes:
JULES_SYSTEM_PROMPTto align with user-provided text.!{echo $VAR}) to Python format ({var}).str.format()compatibility.AGENTS.mdwith changelog entry.Tests passed:
tests/unit/test_triage_agent.pyverified prompt construction and JSON parsing.PR created automatically by Jules for task 1692529356453814078 started by @milhy545