Conversation
- Replaces `JULES_SYSTEM_PROMPT` in `src/mycoder/triage_agent.py` with the user-provided prompt. - Adapts the prompt for Python `str.format()` (placeholders and escaping). - Sanitizes the prompt by removing the "Final Command Construction" section to comply with `json` parsing logic and "No Command Injection" safety constraints. - Updates "No Command Injection" constraint text to match user request. - Verified with unit tests (`tests/unit/test_triage_agent.py`). Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🤖 Hi @milhy545, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Summary of ChangesHello @milhy545, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness and safety of the Jules triage agent by updating its core system prompt. The primary goal is to ensure the agent consistently produces valid JSON output, preventing runtime errors and mitigating potential command injection vulnerabilities. These changes streamline the agent's operation and improve its reliability in processing triage tasks. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the system prompt for the Jules triage agent. However, it introduces a security regression by narrowing a critical safety constraint against command substitution, potentially allowing malicious substitutions via prompt injection from untrusted GitHub issue content. Additionally, one of the changes introduces a contradiction in the prompt's instructions, which could confuse the language model.
| 2. **Label Discipline:** Use ONLY the labels provided in `{available_labels}`. Do not hallucinate new labels. | ||
| 3. **Variable Safety:** Reference variables strictly. | ||
| 4. **No Command Injection:** Do not use command substitution `$()` in generated output. | ||
| 4. **No Command Injection:** Do not use command substitution `$()` in generated shell commands. |
There was a problem hiding this comment.
The change from 'Do not use command substitution explanation field). This also re-introduces the term 'shell commands', creating a contradiction that could confuse the LLM, as the prompt is designed for strictly JSON output. The broader constraint is crucial for preventing arbitrary command execution if the output is processed by a shell-based system.
| 4. **No Command Injection:** Do not use command substitution `$()` in generated shell commands. | |
| 4. **No Command Injection:** Do not use command substitution $() in any part of the generated output. |
This PR updates the system prompt for the Jules triage agent (
src/mycoder/triage_agent.py) based on new directives.The following changes were made:
JULES_SYSTEM_PROMPTwas replaced with the new version provided by the user.str.format()syntax (e.g.,{available_labels}instead of!{echo $AVAILABLE_LABELS}) and JSON braces were escaped ({{/}}).triage_agent.pyscript expects and parses raw JSON output.json.JSONDecodeErrorand crashes the agent.The changes were verified using existing unit tests (
tests/unit/test_triage_agent.py), confirming that prompt construction and JSON parsing remain functional.PR created automatically by Jules for task 10651564694019365064 started by @milhy545