Skip to content

Conversation

@enotniy
Copy link
Collaborator

@enotniy enotniy commented Dec 23, 2025

Add fix for expo ios settings

"expo-build-properties",
  {
    "ios": {
      "useFrameworks": "static"
    }
  }

@enotniy enotniy requested a review from Copilot December 23, 2025 13:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a workaround for use_frameworks! :linkage => :static in iOS Podfile modifications. The change ensures that when a new target is inserted into the Podfile, any existing use_frameworks! directive is also included within that target block.

  • Adds detection of existing use_frameworks! directives in the Podfile
  • Includes the frameworks directive inside newly created target blocks
  • Maintains compatibility with different use_frameworks! configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}

const insertion = `target '${targetName}' do\n ${podLine}\nend\n\n`;
const frameworksMatch = podfile.match(USE_FRAMEWORKS_REGEX);
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use_frameworks! directive is being detected globally but should only be included if it exists within the main target scope or at the root level, not within other targets. This could incorrectly duplicate a use_frameworks! directive that belongs to a different target.

Suggested change
const frameworksMatch = podfile.match(USE_FRAMEWORKS_REGEX);
const mainTargetEndIdx = podfile.indexOf("\nend", headerIdx);
const searchEndIdx = mainTargetEndIdx === -1 ? podfile.length : mainTargetEndIdx;
const frameworksMatch = podfile.slice(0, searchEndIdx).match(USE_FRAMEWORKS_REGEX);

Copilot uses AI. Check for mistakes.
Comment on lines 131 to +133



Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary blank line added at end of file. Remove this trailing newline to maintain consistency.

Suggested change

Copilot uses AI. Check for mistakes.
@mindbox-cloud mindbox-cloud deleted a comment from github-actions bot Dec 23, 2025
@enotniy enotniy merged commit 08c7b5a into develop Dec 23, 2025
6 of 7 checks passed
@enotniy enotniy deleted the hotfix/use_frameworks branch December 23, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants