Introduce EC variant #402
Open
Introduce EC variant #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR introduces support for an "EC variant" that allows running enterprise-specific mc functional tests from a separate repository. The implementation adds conditional logic to switch between upstream mc tests and EC-provided tests based on environment configuration.
- Adds
MINT_MC_VARIANTenvironment variable to select betweenmc(default) andectest variants - Modifies the test runner to conditionally execute EC tests from a mounted repository when variant is set to
ec - Updates installation script to skip upstream
mcinstallation when EC variant is selected
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| run/core/mc/run.sh | Adds case statement to handle mc vs ec variants with configurable EC repo directory and runner script paths |
| run/core/mc/README.md | Documents the new EC variant feature including required environment variables and directory structure |
| build/mc/install.sh | Adds early exit when EC variant is selected to skip upstream mc installation |
| README.md | Adds MINT_MC_VARIANT environment variable to the main configuration table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This PR can go out independently. |
rraulinio
requested review from
harshavardhana,
prakashsvmx,
shtripat and
zveinn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce EC variant to run specific functional tests under a separate repo.