Avoid truncating Windows SOCKET to int #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a soundness issue, as despite winsock usually returning small values like 0x00000000000000C8, we have no guarantee that a winsock SOCKET can be safely truncated to an int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winsock's SOCKET typedef is as wide as a pointer (it's a typedef of UINT_PTR), but libnatpmp implicitly casts it to an int (as other platform's sockets are ints.)
This is a soundness issue, as despite winsock usually returning small values like 0x00000000000000C8, we have no guarantee that a winsock SOCKET can be safely truncated to an int.