Restrict the width of the player info table on the player detail page#1696
Open
smismib wants to merge 1 commit intominj:masterfrom
Open
Restrict the width of the player info table on the player detail page#1696smismib wants to merge 1 commit intominj:masterfrom
smismib wants to merge 1 commit intominj:masterfrom
Conversation
Owner
|
Thank you for your PR but I do not think this is ready to be merged as is. Are you sure this is not caused by either of the following?:
I do not agree with your solution of adjusting CSS in a random util function. My suspicion is this needs to live next to the wage feature. Please take a look at |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Texts are too long if wage options are enabled, causing the problem in the div on its right in certain languages (Chinese and Japanese at least as far as I know).
Restrict the width of player info table on player detail page if the skills are visible under the new design.
Current Chinese version behaviour

After the fix

Current English verison

English version after the fix
