Merged
Conversation
- Added validation for the version control system in the Pipeline component, including checks for configuration, GitHub CLI installation, and user authentication. - Introduced error handling to display validation messages in the UI when issues are detected. - Enhanced RepoConfig component to allow editing of the version control system configuration. - Updated tests to cover new validation logic and ensure proper functionality of version control system handling. - Updated skyline.config.json to include default version control system as GitHub. - Refactored related components and tests to support the new validation features.
- Simplified the header component by moving the onpagenavigation handler to the container div. - Enhanced the pagenavigation event in the header and pipeline components to include bubbles and composed properties for better event propagation. - Updated the pipeline component to conditionally display the search bar based on validation errors, improving user experience. - Added a new computed property in the pipeline component to check for validation errors, enhancing error handling capabilities.
- Introduced a new GitHubVersionControlSystem class to handle GitHub-specific version control operations, including validation of CLI installation and authentication, searching, creating, updating, and closing pull requests. - Implemented a VersionControlSystemFactory to manage the creation of version control system instances, allowing for future extensibility to other systems. - Updated the Pipeline component to integrate the new version control system, enhancing the handling of pull requests and improving error management. - Added TypeScript definitions for version control types to ensure type safety and clarity in the implementation. - Refactored existing code to utilize the new version control system structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Pipeline: Version Control System Validation & Extensibility
This introduces a robust version control system validation framework and improves the pipeline component's error handling and extensibility. The changes lay the foundation for supporting multiple version control systems while currently implementing GitHub as the first supported platform.