FinalizerHandler updates#193
FinalizerHandler updates#193mitchspano merged 2 commits intomitchspano:mainfrom jamessimone:update-finalizers
Conversation
…dated lint/PMD scanning to pre-commit hooks
| DML_Finalizer__mdt first, | ||
| DML_Finalizer__mdt second | ||
| ) { | ||
| Integer difference = (first.Order__c - second.Order__c).intValue(); |
There was a problem hiding this comment.
Order__c has some decimal places defined with the intention that people can slot actions between each other without needing to update all subsequent Order__c values.
Perhaps that was not the proper design in hindsight as all are eventually sequenced so they map to non-negative integers anyway. Regardless, if a decimal place is used, then integer rounding can lose some fidelity in the ordering.
I think we need to keep (first.Order__c - second.Order__c) as a decimal for now, and potentially revisit the precision on Order__c as a new breaking change in a major package version.
There was a problem hiding this comment.
ah yeah, great call - wasn't aware of that level of precision, but in retrospect it makes sense! I will back out this particular change, thanks for the catch
…based orderings for finalizers
2 participants
Booleanparameters