Merged
Conversation
* Card updated default and hover states * Base list card components * List card styles * Learning format and border separator * Use embedly URLs for images * Styles for mobile * Loading view and buttons styling * List card stories * Remove size * Style lint fixes * Pass href to navigate instead of open drawer. Add list count for learning paths * Position buttons absolute and outside of Link container * Positioning and set class on wrapper * Test fixes * Reinstate non link card variant. Update tests * Style lint fix * Default image for list cards * Provide actions buttons to search items * Position actions dependent on image * Test for list variant * Relative API base path for local * Use TruncatedText for title * Hook to provide open drawer href to list component * Replace breakpoint hook with css * Fix test (bad css). Apply drawer href hook to Cards
* remove padding from FieldControls element * making margin on breadcrumb 16px * font size adjustments * fixing width for right panel * adding mail outline icon * adjusting margins around text container and subscribe button * visual tweaks * changing body text * minor visual tweaks * padding tweaks * fixing background placement and padding adjustments * style fixes * slight width adjustment * font fixes * ui tweaks * removing unused alt attributes * adding reversed banner images * Revert "adding reversed banner images" This reverts commit 9a72754. * Reapply "adding reversed banner images" This reverts commit 9a45c26. * adding dimmable background * some lint * removing some margin * removing duplicate css * fixing lint * fixing broken test * background image size adjustment * adding default bg constant * fixing background dimming and zindex issues * fixing banner padding to match figma * fixing responsive sizing of channel box * fixing padding * fix ordering of elements * lint fix and padding * fixing interior padding for sm dimension * lint fix * lint fix * padding adjustment * pushed fix for padding * revert heading change
odlbot
added
waiting for checkboxes
all checkboxes checked
and removed
deploying to rc
waiting for checkboxes
labels
odlbot
added
deploying to prod
deployed to prod
and removed
all checkboxes checked
deploying to prod
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shankar Ambady
Jon Kafton