Homepage Stories & Events layout fixes#1103
Merged
Conversation
shanbady
requested changes
Jun 17, 2024
Contributor
shanbady
left a comment
There was a problem hiding this comment.
style changes Look good. one discrepancy i saw was that the news events did not have any action buttons as shown in the figma. might be outside the scope of this ticket but is this expected?
Contributor
Author
To my knowledge news/events don't have action buttons (the learning resource "add to user list" and admin "add to learning path" don't apply). |
shanbady
approved these changes
Jun 17, 2024
Contributor
shanbady
left a comment
There was a problem hiding this comment.
in that case looks like there is just the test to fix before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4477
Description (What does it do?)
Card default and hover state design updates were done in previous PR (Learning Resource cards, list view #1054).
Fixes the bottom horizontal alignment on the News and Events Homepage section cards.
3+4. vertically centers the title in the event cards.
Screenshots (if appropriate):
How can this be tested?
Load the Homepage and check that the above items are addresses and the layout matches the designs.
Additional Context
Previously:
