Make min max product price required #3262
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
annagav
force-pushed
the
ag/import_course_with_min_max_price
branch
from
90dc4b8 to
54c8e01
Compare
for more information, see https://pre-commit.ci
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+15
to
+23
|
|
||
| ProgramPage = apps.get_model("cms", "ProgramPage") | ||
| for program in ProgramPage.objects.filter(min_price=None): | ||
| program.min_price = program.price if program.price is not None else 0 | ||
| program.save(update_fields=["min_price"]) | ||
|
|
||
| for program in ProgramPage.objects.filter(max_price=None): | ||
| program.max_price = program.price if program.price is not None else 0 | ||
| program.save(update_fields=["max_price"]) |
There was a problem hiding this comment.
Bug: The data migration incorrectly assigns the price StreamField object directly to the min_price SmallIntegerField, which will cause data loss or a crash during migration.
Severity: CRITICAL
Suggested Fix
Update the migration logic to correctly parse the numeric value from within the price StreamField. It should iterate through the stream blocks, access the price_details block, and extract the numeric value from its text field (e.g., price[0].value['text']), converting it to an integer. The check for an empty stream should also be corrected (e.g., if course.price:).
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: cms/migrations/0055_populate_min_max_price.py#L15-L23
Potential issue: The data migration attempts to populate the new `min_price` and
`max_price` fields from the existing `price` `StreamField`. However, the logic
`course.min_price = course.price if course.price is not None else 0` is incorrect. It
assigns the entire `StreamField` object, not a numeric value from within it, to the
`SmallIntegerField`. Additionally, the condition `course.price is not None` is almost
always true for a `StreamField`, which returns an empty list-like object when empty, not
`None`. This will cause the migration to either fail due to a type mismatch or silently
convert all values to 0, effectively losing existing price data.
Did we get this right? 👍 / 👎 to inform future reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fix https://github.com/mitodl/hq/issues/9910
Description (What does it do?)
makes min max price required on the product page
validates min_price and max_price are set when saving the course page in the CMS
How can this be tested?
Run the migrations
Take a look at your existing product pages.
Make sure min max price were populated from the existing price field.
Go to program or course page make sure that the fields are required now.