Draft
Conversation
Add two pytest tests in hubspot_sync/api_test.py for make_contact_sync_message_from_user: one verifies a minimal user (no legal_address or user_profile) still yields name and email and omits country/state/profile fields; the other verifies an empty name is preserved as an empty string in the properties. Both tests patch upsert_custom_properties and use django_db.
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
cp-at-mit
changed the title
Remove direct HubSpot sync from the ApisixRemoteUser backend and add a dedicated post_save signal to sync newly created User instances. users.apps.UsersConfig now imports users.signals in ready(), and users.signals defines sync_user_to_hubspot_on_create (with a dispatch_uid) to call hubspot_sync.task_helpers.sync_hubspot_user when a User is created. This decouples HubSpot syncing from the authentication backend and avoids duplicate or premature syncs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/10032
Description (What does it do?)
When user's are created via SCIM (the user creates their account via Learn), then they're not synced with Hubspot from MITx Online.
How can this be tested?