Open
Conversation
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
rachellougee
reviewed
Feb 5, 2026
Contributor
rachellougee
left a comment
rachellougee
left a comment
There was a problem hiding this comment.
The certificate now displays issue_date when it's set, but shows empty when it isn't. Since issue_date is not required, we should add a default value.
| "learner_name": self.certificate.user.get_full_name(), | ||
| "start_date": start_date, | ||
| "end_date": end_date, | ||
| "issue_date": self.certificate.issue_date, |
Contributor
There was a problem hiding this comment.
This works if issue_date is set, but over 2000 certificates don't have an issue_date, can we add a default? maybe created_on?
e.g. https://mitxonline.mit.edu/admin/courses/courseruncertificate/59293/change/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Related to https://github.com/mitodl/mitxonline/pull/3025/changes
Description (What does it do?)
Update certificate to show issue date
Screenshots (if appropriate):
How can this be tested?
Created a certificate, go to view it
Make sure that the date shown is the issue date.