Add test coverage for useIpAddressForGeolocation config fix #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests to verify false values are correctly returned (fixes #315) - Test all falsy values (false, 0, null, undefined, empty string) - Add regression tests to prevent the bug from recurring - Test multi-token support and config isolation - Verify integration with network layer IP parameter conversion - Ensure default behavior returns true when not configured This prevents regression of the bug where getUseIpAddressForGeolocation always returned true due to the || true fallback, making it impossible to disable IP-based geolocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getUseIpAddressForGeolocationfix from PR Fix getUseIpAddressForGeolocation always returning true #316trueChanges
__tests__/config.test.jswith 16 test casesTesting
falsevalues now correctly persist as expectedWhy This Matters
The original bug made it impossible to disable IP-based geolocation tracking, which has privacy and GDPR implications. This test suite ensures the fix remains effective and prevents future regressions.
Test Coverage Areas
truewhen not configuredtrueandfalsetrue