adding support for recv_into - used by python3#15
Open
saurabh-hirani wants to merge 1 commit intomjs:masterfrom
Open
adding support for recv_into - used by python3#15saurabh-hirani wants to merge 1 commit intomjs:masterfrom
saurabh-hirani wants to merge 1 commit intomjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As python3 uses
recv_intoand it is not patched by current gevent_openssl, a grequests call with pyopenssl installed falls back to https://github.com/urllib3/urllib3/blob/1e9ab5aee042ff0158d0f443bc600ef3a2e7bf9a/src/urllib3/contrib/pyopenssl.py#L302 making the code slow.This issue is explained in depth at:
However, to keep the focus on the current patch, this issue can be replicated by following these steps:
pip3 install gevent-opensslhttps://localhost:8082/delay/1to introduce a 1 second delay in response.pip3 uninstall gevent-openssl