feat: Switching to dynamic sudo prefix based on root privileges #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add hasRootPrivileges() function to check if running with root/admin privileges - Implement getSudoPrefix() to return 'sudo' only when needed - Update installCudaLinuxLocal() to use dynamic sudo prefix - Update installCudaLinuxNetwork() to use dynamic sudo prefix for all package manager commands - Remove hardcoded 'sudo' from container test workflow
mjun0812
changed the title
- Add 'needs' dependency to Test job to ensure quality checks pass before running tests - Update compiled distribution files to reflect source code changes for dynamic sudo prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implemented a feature to dynamically determine the command prefix based on execution privileges, avoiding unnecessary
sudocommands when already running with root privileges in container environments or similar.Changes
hasRootPrivileges()function to determine if running with root/administrator privileges.getSudoPrefix()function to return 'sudo' only when necessary.installCudaLinuxLocal()to use the dynamic sudo prefix.installCudaLinuxNetwork()to use the dynamic sudo prefix.How to Test
sudois not prepended.sudois correctly prepended.