Add option for raising an error on missing ENV variable#33
Open
Brias wants to merge 1 commit intomkaranasou:mainfrom
Open
Add option for raising an error on missing ENV variable#33Brias wants to merge 1 commit intomkaranasou:mainfrom
Brias wants to merge 1 commit intomkaranasou:mainfrom
Conversation
efe8a09 to
246cd58
Compare
|
+1. If anything, should be the default behavior of raise_if_na. Sometimes you just don't have a default value. |
|
+1, very useful! @mkaranasou - can we get this merged, once you have a spare moment? |
|
I realize it's a long shot given how long it's been, but I imagine this behavior is more useful than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #22 by adding a
raise_if_missingoption to theparse_configfunction.If
raise_if_missingis set toTrue, aValueErroris raised when the following conditions are met:Example:
For backwards compatibility,
raise_if_missingis set toFalseby default.