change: Reorganize as griffe and griffelib packages with uv workspaces
#434
Conversation
johnslavik
force-pushed
the
b/migrate
branch
from
cc4c9c5 to
e9221d0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
@copilot Look at https://github.com/mkdocstrings/griffe/actions/runs/19806731977/job/56741990187?pr=434. Fix all incorrect refs |
|
@johnslavik I've opened a new pull request, #437, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
I'm going over the whole pipeline (docs, usage, etc) now, addressing these and other issues on the way. |
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
…[pypi] Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
`uv build --all` now works
|
@pawamoy, I'd say this is ready. The documentation changes are not complete, but I suggest we iterate on the docs later. I'd also say let's not release this yet before the documentation is fully updated. |
|
We can also add a test to our API tests to cover the scenario where |
| and isinstance(node.value.args[1], ast.Constant) | ||
| ): | ||
| build_path = Path(node.value.args[1].value, "src") # type: ignore[arg-type] | ||
| build_path = Path(node.value.args[1].value, "packages/griffelib/src") # type: ignore[arg-type] |
There was a problem hiding this comment.
| build_path = Path(node.value.args[1].value, "packages/griffelib/src") # type: ignore[arg-type] | |
| build_path = Path(node.value.args[1].value, "src") # type: ignore[arg-type] |
There was a problem hiding this comment.
Couldn't have applied this one because it broke tests.
There was a problem hiding this comment.
Yep, tests must be fixed accordingly :) (this code is part of our finder logic, surely we don't want to hardcode any griffe-specific paths in there)
There was a problem hiding this comment.
Working on the fix. Thank you for pointing me to the right direction, I wasn't thoughtful on this one!
There was a problem hiding this comment.
Thanks, of course! Don't hesitate to use something else than "griffe" in tests if that makes it easier / less confusing / less error-prone 🙂
Thanks! Co-authored-by: Timothée Mazzucotelli <dev@pawamoy.fr>
Co-authored-by: Timothée Mazzucotelli <dev@pawamoy.fr>
Co-authored-by: Timothée Mazzucotelli <dev@pawamoy.fr>
|
Perhaps we can also add |
Continuation of #431, based on #433, closes #408
Migration script: https://gist.github.com/johnslavik/76d556a427033c4de2d236d67aa05b8f