Open
Conversation
mkremnev
force-pushed
the
lessons/lesson14
branch
from
2c0de7b to
9e9a181
Compare
vvscode
reviewed
Sep 25, 2020
Comment on lines
+4
to
+13
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Otus project Game of Life</title> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="app"></div> | ||
| </body> | ||
|
|
There was a problem hiding this comment.
давай в следующий раз без лишних изменений (тех, которые к домашке не относятся)
vvscode
reviewed
Sep 25, 2020
|
|
||
| // Задание 1 | ||
| test('team to team', () => { | ||
| const originalTeam: OriginalTeam = Object.freeze({ |
Owner
Author
There was a problem hiding this comment.
Фриз было в самом репозитории домашки, я не менял ничего.
vvscode
reviewed
Sep 25, 2020
Comment on lines
+17
to
+27
| const withoutSize = Object.entries(originalTeam).filter( | ||
| (value) => value[0] !== 'size', | ||
| ); | ||
| const newValueKeyOfName = withoutSize.map((value) => { | ||
| if (value[0] === 'name' && value[1] !== 'New York Badgers') | ||
| value[1] = 'New York Badgers'; | ||
| return value; | ||
| }); | ||
| const teamNew = Object.fromEntries( | ||
| (newValueKeyOfName as unknown) as string[], | ||
| ); |
Owner
Author
There was a problem hiding this comment.
Согласен, надо пересмотреть будет
vvscode
reviewed
Sep 25, 2020
| export const originalArrayToExpectedArray = ( | ||
| originalArray: SomeArray, | ||
| ): SomeArray => { | ||
| const cloneArrayWithoutFirstElement = originalArray.slice(2); |
Owner
Author
There was a problem hiding this comment.
Так клонировать же надо без первого элемента, не пойму как можно сделать это рестом
vvscode
reviewed
Sep 25, 2020
| const objectToArray = Object.entries(qsObj); | ||
| const elementJoinEquals = objectToArray.map((val) => val.join('=')); | ||
| const stringJoinAmp = elementJoinEquals.join('&'); | ||
| const propsWithSymbol = stringJoinAmp.replace(/^/, '?'); |
There was a problem hiding this comment.
зачем replace если ты просто добавляешь символ?
Owner
Author
There was a problem hiding this comment.
Согласен, лишнего сделал
vvscode
reviewed
Sep 25, 2020
| // Задание 3 | ||
|
|
||
| export const parseQs = (qs: string): QsObj => { | ||
| const propsWithoutSymbol = qs.replace(/\?/y, ''); |
There was a problem hiding this comment.
тебе же только первый вопрос убрать нужно, в смысле если он на первом месте
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.