Fix memory leak in transforms (#2841) #2853
Open
+40
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes memory leak in function transforms when a container is updated with a tracer and that container element is reused as input (issue #2841).
Root cause: When
vjp()/jvp()create tracer copies and a container stores the tracer, subsequent calls create a chaincopy(copy(copy(...)))that grows unboundedly, this is what prevents the garbage collection.Solution: Flatten copy chains from previous (completed) tracing calls by traversing to the original source before creating new tracers. Only applies to non active tracers to preserve nested transform behavior.
Changes:
vjp()andjvp()intransforms.cppto flatten copy chainstest_grad_with_container_reuseto verify fixFollow the discussion in issue #2841 page for more details about the problem and the solution.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes