View-only layout ops mover #2920
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
View-only layout ops (e.g.
expand_dims,squeeze) can sit between elementwise ops and reduce compile’s fusion opportunities.This PR adds a small “layout mover” step in compile_simplify that (conservatively) rewrites view(op(x)) -> op(view(x)), and runs it to a bounded fixpoint so the view can move up multiple elementwise layers.
This is an early draft to get feedback on whether MLX wants this optimization before I refine/extend it (e.g. consider
reshape,flatten...).Before:

After:

Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes