feat(fft): Implement scaled FFT primitive to optimize VJP #2953
+126
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements a scale parameter for the FFT primitive and updates the FFT::vjp (Vector Jacobian Product) to utilize this parameter. Previously, the VJP for FFT involved explicit Multiply nodes to handle 1/N scaling and symmetry masks. By integrating the scaling factor directly into the FFT primitive:
The computation graph is simplified (fewer nodes).
Performance is potentially improved by fusing the scaling operation into the FFT kernel execution on both CPU and Metal backends.
The FFT primitive constructor and is_equivalent checks have been updated to support the new member variable.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes