Revert 4 KVCache changes made in main#238
Merged
FileSystemGuy merged 4 commits intomainfrom Feb 15, 2026
Merged
Conversation
Removed optional dependencies and ShareGPT dataset loader from kv-cache.py.
Updated script for KV Cache Storage Benchmark to reflect new author attribution and modified test parameters for MLPerf submissions.
Updated README to include initial implementation details and enhanced overview of the KV Cache benchmark for MLPerf Storage v3.
Updated benchmark commands and metrics for clarity and accuracy. Merged ShareGPT functionality into main script, added unit tests, and introduced Excel export capabilities.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
FileSystemGuy
requested review from
dslik,
idevasena,
russfellows and
wvaske
russfellows
approved these changes
Feb 13, 2026
russfellows
left a comment
russfellows
left a comment
There was a problem hiding this comment.
OK, it seems that Curtis knows what he wants, approving the reversion.
idevasena
approved these changes
Feb 13, 2026
Contributor
|
looks good, changes are covered in modular refactor so safe to delete |
Contributor
|
it needs one more approver, i cant rebase #235 until the PR is merged |
johnugeorge
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts 4 files in the KVCache directory in main to their status just after the base integration of the KVCache code so that conflicting changes in the major refactoring work that Hazem has done can be smoothly integrated without conflicts.