Open
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
sean-smith
changed the title
Author
|
recheck |
Contributor
|
Added comments on the issues, can you please revert the git based changes - the other 2 look good. |
Author
Done ✅ |
* Remove subpath from pretrain_llama.py * Install toml package * Adjust --gres=gpu:8 to number of user specified devices Signed-off-by: Sean Smith <seasmith@nvidia.com>
| mem="0", | ||
| exclusive=True, | ||
| gres="gpu:8", | ||
| packager=run.GitArchivePackager(subpath="large_language_model_pretraining/nemo", ref="HEAD"), |
Contributor
There was a problem hiding this comment.
Can you please revert packager=run.GitArchivePackager(subpath="large_language_model_pretraining/nemo", ref="HEAD"), as well?
Author
There was a problem hiding this comment.
I can however I don't understand who is able to run this. If you follow the instructions in the readme this will fail since the path is wrong.
Maybe if you move the Dockerfile to the root directory and build there then this will work, i.e.
cp Dockerfile ../..
cd ../..
docker build -t nemo .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #821, #820, #824