Skip to content

Comments

GPT-OSS-20B Pretraining#862

Merged
ShriyaRishab merged 40 commits intomlcommons:masterfrom
suachong:master
Feb 20, 2026
Merged

GPT-OSS-20B Pretraining#862
ShriyaRishab merged 40 commits intomlcommons:masterfrom
suachong:master

Conversation

@suachong
Copy link
Contributor

This PR provides the reference code for GPT-OSS-20B using Primus framework that can be run on both AMD and NVIDIA hardware.

@github-actions
Copy link

github-actions bot commented Jan 19, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@suachong suachong marked this pull request as ready for review January 23, 2026 17:50
@suachong suachong requested a review from a team as a code owner January 23, 2026 17:50
@ShriyaRishab
Copy link
Contributor

@mmarcinkiewicz can you please review this?

@mmarcinkiewicz
Copy link
Contributor

It seems the datadir needs to be writeable (presumably to store the index) - can we put index into a different dir so the datadir stays RO?

Copy link

@pbaumstarck pbaumstarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall and I got the code running. Another minor comment that we don't have any binary whl files in the repo, so it'd be ideal if we could dynamically retrieve and install that.

@mmarcinkiewicz
Copy link
Contributor

mmarcinkiewicz commented Feb 20, 2026

now I'm looking into it - where is the mlperf logging being done? I see MLPerfMegatronPretrainTrainer which probably contains is, but it's hidden in Primus?
While it might be annoying, I think we should have explicit callbacks here in the reference code so people can see how (and when) the mlperf logs are being triggered

Copy link
Contributor

@ShriyaRishab ShriyaRishab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in the task force meeting

@ShriyaRishab ShriyaRishab merged commit 4e3737b into mlcommons:master Feb 20, 2026
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants