This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Open
Conversation
Jest to snapshot test Storybook examples. emotion-jest pkg snapshots …
…into babel-setup
Babel and Jest Storybook Snapshots
Collaborator
|
@jonearley - Does http://localhost:9000/?path=/story/universal-header--default still work for you? |
Contributor
Author
|
@respinos Nope, I get the same error. Not sure why, the UniversalHeader and Chat work when docs are running locally. Docs uses the build lib whereas Storybook uses src, but having Storybook use lib didn't seem to make a difference. Will let you know what I find out! |
Collaborator
|
The console messages were ... well, not helpful but less gibberish: |
Storybook will use `react-scripts` config if it's installed. This is easier than maintaining our own.
Contributor
Author
Contributor
Author
|
Now I'm battling css emotion props not working right... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Lerna and the mono-repo structure. This PR has one package:
@umich-lib/core.The DS end user consumes everything through
@umich-lib/coreso it was making less sense to develop as a mono-repo.Tooling seems to either support single package repos or mono repos and that has caused a lot of hurdles. The tipping point was Netlify not knowing what todo with a mono-repo. I wanted to add Netlify to have preview builds on PRs (they're working with this change, see below).
Sorry for so many changes in one PR 🙃.
Do we have any concerns with dropping Lerna? cc @bridgetburke, @respinos