[TimescaleDB] Replace TDEngine with TimescaleDB for model monitoring #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxtkr77
force-pushed
the
ML-11627/timescaledb-support
branch
from
35296dc to
dfaafbb
Compare
added 2 commits
December 25, 2025 13:40
Add TimescaleDB as an optional TSDB backend for MLRun model monitoring, providing an alternative to TDEngine. - Add timescaledb section in values.yaml (disabled by default) - Add StatefulSet, Service, and Secret templates - Add helper templates for labels, selectors, and connection string - Use timescale/timescaledb-ha:pg16-ts2.17.2-all image Reference: ML-11482
Remove TDEngine and use TimescaleDB as the sole time-series database backend for model monitoring. - Remove TDEngine templates (statefulset, service, configmap) - Remove TDEngine configuration from values.yaml - Remove TDEngine helper templates from _helpers.tpl - Update admin_installation_values.yaml to reference timescaledb - Enable TimescaleDB by default Reference: ML-11482
alxtkr77
force-pushed
the
ML-11627/timescaledb-support
branch
from
dfaafbb to
b00d396
Compare
There was a problem hiding this comment.
Pull request overview
This PR replaces TDEngine with TimescaleDB as the time-series database for MLRun CE model monitoring. The change involves removing all TDEngine-related Helm templates and configuration, and introducing a new TimescaleDB StatefulSet deployment with PostgreSQL 17 and TimescaleDB extensions.
Key Changes:
- Complete replacement of TDEngine with TimescaleDB including StatefulSet, Service, and Secret templates
- Updated
values.yamlwith TimescaleDB-specific configuration (image, auth, persistence, resources) - Added TimescaleDB helper templates to
_helpers.tplfor naming, labels, and connection strings - Added
kind-test.shscript for local testing with Kind cluster
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/kind-test.sh | New bash script for testing MLRun CE deployment on local Kind cluster with TimescaleDB verification |
| charts/mlrun-ce/values.yaml | Replaced tdengine configuration with timescaledb section including auth, persistence, and resource settings |
| charts/mlrun-ce/templates/timescaledb/statefulset.yaml | New StatefulSet template for TimescaleDB deployment with PostgreSQL 17, health probes, and persistent storage |
| charts/mlrun-ce/templates/timescaledb/service.yaml | New ClusterIP Service exposing TimescaleDB on port 5432 |
| charts/mlrun-ce/templates/timescaledb/secret.yaml | New Secret template storing TimescaleDB authentication credentials |
| charts/mlrun-ce/templates/tdengine/statefulset.yaml | Removed TDEngine StatefulSet template completely |
| charts/mlrun-ce/templates/tdengine/service.yaml | Removed TDEngine Service template completely |
| charts/mlrun-ce/templates/tdengine/configmap.yaml | Removed TDEngine ConfigMap template completely |
| charts/mlrun-ce/templates/_helpers.tpl | Replaced tdengine helper templates with timescaledb equivalents for naming, labels, and connection strings |
| charts/mlrun-ce/admin_installation_values.yaml | Updated reference from tdengine to timescaledb |
| charts/mlrun-ce/Chart.yaml | Bumped chart version from 0.10.1-rc3 to 0.10.1-rc4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
January 4, 2026 10:51
- Add urlquery encoding for username/password in connection string helper to handle special characters properly - Pin image tag to specific version pg17.7-ts2.24.0 for reproducible deployments
Use trap with RETURN signal to ensure temp values file is cleaned up even if helm command fails, making the script suitable for CI/CD use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Changes
timescaledbsection tovalues.yamlwith configurable image, auth, persistence, and resourcesstatefulset.yaml,service.yaml,secret.yaml_helpers.tpladmin_installation_values.yamlto reference timescaledbTest plan
Related PR
mlrun/functions#961