-
Notifications
You must be signed in to change notification settings - Fork 43
[FEAT] Update MLrun UI React 18 to 19 #3515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Impl [UI] update dev dependencies libraries
| }, | ||
| [searchRef] | ||
| ) | ||
| // === ΠΠ±ΡΠΈΡΠ»Π΅Π½Π½Ρ ΡΠΈΡΠΈΠ½ΠΈ ΡΠ½ΠΏΡΡΠ° ΠΏΡΡΠ»Ρ ΠΌΠΎΠ½ΡΡΠ²Π°Π½Π½Ρ === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove comnent
| }) => { | ||
| const [searchValue, setSearchValue] = useState(value ?? '') | ||
| const [label, setLabel] = useState('') | ||
| // const [label, setLabel] = useState('') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we don't need it, pls remove
| } | ||
|
|
||
| onChange(value) | ||
| // === ΠΡΠ½ΠΎΠ²Π½Π° Π»ΠΎΠ³ΡΠΊΠ° ΠΎΠ½ΠΎΠ²Π»Π΅Π½Π½Ρ Π·Π½Π°ΡΠ΅Π½Π½Ρ === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove the comment
|
|
||
| const matchOnClick = item => { | ||
| setLabel('') | ||
| // === ΠΠ»ΡΠΊ Π½Π° Π΅Π»Π΅ΠΌΠ΅Π½Ρ Π·Ρ ΡΠΏΠΈΡΠΊΡ === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove the comment
| } | ||
|
|
||
| const handleSearchIconClick = event => { | ||
| // === ΠΠ»ΡΠΊ ΠΏΠΎ ΡΠΊΠΎΠ½ΡΡ ΠΏΠΎΡΡΠΊΡ === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove the comment
| dataInputState.storePathType | ||
| ) | ||
| })) | ||
| //TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add more specific todo
| setFunctions([]) | ||
| }) | ||
|
|
||
| //TODO: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add more specific todo
|
|
||
| const formRef = React.useRef( | ||
| createForm({ | ||
| // const formRef = React.useRef( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove
π Description
Update MLrun UI repo from React vs 18 to 19
π οΈ Changes Made
β Checklist
π References
π¨ Potentially Breaking Changes
Includes DRC change