Skip to content

Conversation

@RaphaelS1
Copy link
Collaborator

@RaphaelS1 RaphaelS1 commented Jan 30, 2026

I think these chapters are really strong. Suggestions/comments in this PR. Important to note:

  1. The diagram in Chapter 15 only refers to reductions to regression and classification; doesn't include reductions for EHA to single event
  2. Added a line in Chapter 16 saying IPCW requiring independence conditional on covariates (consequence of KM), please check, also would we want to comment that other models instead of KM could be used to relax this?
  3. I removed the example in Chapter 17 showing consistency of PV because it included summing over all pseudo-values but we don't show them all, so it just read really strangely, like you were trying to prove something using real data but then not providing the data. I don't think it added anything beyond the stated theory

RaphaelS1 and others added 2 commits January 30, 2026 08:55
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
@github-actions
Copy link

Book 📖

RaphaelS1 and others added 11 commits January 30, 2026 09:50
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
Signed-off-by: Raphael Sonabend <raphaelsonabend@gmail.com>
@RaphaelS1 RaphaelS1 requested a review from adibender January 30, 2026 16:11
@RaphaelS1 RaphaelS1 changed the title [WIP] reductions comments reductions comments Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remaining reduction issues

3 participants