Skip to content

Comments

Fixes for Issues #19, #23, #31, #32 and #33#36

Open
jameseleach wants to merge 9 commits intommone:masterfrom
jameseleach:master
Open

Fixes for Issues #19, #23, #31, #32 and #33#36
jameseleach wants to merge 9 commits intommone:masterfrom
jameseleach:master

Conversation

@jameseleach
Copy link

Send the three GCode commands with one OctoPrintClient.control.sendGcode
command by sending an array of strings instead of three separate commands
with individual strings.

This ensures that the three move commands are always processed in order.

Send the three GCode commands with one OctoPrintClient.control.sendGcode
command by sending an array of strings instead of three separate commands
with individual strings.
Multiple line Gcode commands must be sent as an array of strings.
@jameseleach
Copy link
Author

This same technique (sending multiple Gcode commands as an array of strings instead of a single string) is also a potential resolution to #19 and #32.

I'm unable to test the changes to klipper_param_macro.js at the moment but will do so when I can - or if someone else can test and leave feedback that'd be appreciated.

@jameseleach jameseleach changed the title Fix for Issue #31: Fixes for Issues #19, #23, #31, #32 and #33 Feb 16, 2019
@DMCShep
Copy link

DMCShep commented Jan 3, 2020

Is there any chance of seeing this merged? This is a rather big ticket item, we get people on the Klipper Discord having their config files wiped out and they aren't even aware this is a known issue nor that there is an active fix for it.

@baodrate
Copy link

baodrate commented Feb 4, 2020

Is there anyone already maintaining a fork, since this repo seems abandoned (no hate, just sayin)? If no one's up for it I'll give it a shot, but I'm not that familiar with Octoprint's code.

@jameseleach
Copy link
Author

"Maintaining a fork" is a bit strong of a term.. But I do have the fork I did to fix these bugs. I've not been doing any 3d printing for a while and have just installed a Pi with OctoPrint and noticed that the OctoprintKlipperPlugin is no long listed... Not sure what the best option is to remedy this situation!

@JohnEdwa
Copy link

@jameseleach If you, or someone else, wants to take over maintaining the plugin the process is dead simple - just post an issue asking if the plugin is abandoned or not (which it clearly is) and after two weeks, you can open an issue at https://github.com/OctoPrint/plugins.octoprint.org/issues and ask for the plugin to be transferred to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants