Feat added internet permission #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
moak13
requested changes
Jan 3, 2024
Owner
moak13
left a comment
moak13
left a comment
There was a problem hiding this comment.
Here are some concerns to look out for, Thanks.
|
|
||
| final response = await _dishService.createDish(info); | ||
|
|
||
| if (response != null) { |
Owner
There was a problem hiding this comment.
Hmm, actually for this, you need to take care of the null, it's something that can happen and we need to let the user know that an unknown error has occurred. Using the negative first approach to building the success area in a try-and-catch block helps solve a lot in the mobile space.
| @@ -41,6 +41,7 @@ class SignupViewModel extends FormViewModel { | |||
| await _dialogService.showDialog( | |||
| description: "Account created successfully.", | |||
Owner
There was a problem hiding this comment.
I thought we are using l10n for our texts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.