feat/ added internet permission #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moak13
requested changes
Jan 23, 2024
| title: S.current.unknown_error, | ||
| ); | ||
| if (dialogResponse?.confirmed == true) { | ||
| _navigationService.back(); |
Owner
There was a problem hiding this comment.
An error occurred when creating a new dish, so we are still meant to be on the creat dish page when we pop the dialog. No need routing to anywhere, the users will do that on their own if they feel like it.
Contributor
Author
There was a problem hiding this comment.
I have resolved the fix by removing the navigator and if-else
| if (dialogResponse?.confirmed == true) { | ||
| _navigationService.back(); | ||
| } | ||
| } else { |
Owner
There was a problem hiding this comment.
no need for an else, if the if condition is not met, the code will continue the flow
Contributor
Author
There was a problem hiding this comment.
I have resolved this as well
| } else { | ||
| await _dialogService.showDialog( | ||
| description: S.current.account_created_successfully, | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Internet permission for release mode
Handled plausible Null Errors in newDish VM and signup VM