Update plot creation #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I just tried this out on a larger dataset on a dev device and it seems there's still a few kinks to iron out in the axis generation. |
LostKobrakai
commented
Jun 24, 2022
Comment on lines
+59
to
+62
| # TODO inject via history instead of using up 10s per test | ||
| Stream.interval(1000) | ||
| |> Stream.map(fn val -> execute_telemetry([:some], %{value: val}) end) | ||
| |> Enum.take(10) |
Contributor
Author
There was a problem hiding this comment.
This seem to let CI fail. I'd love to get some guidance on maybe seeding the test with a history file instead of waiting just to setup the mobius instance.
Collaborator
|
@LostKobrakai sorry for the delay I have been pulled into other projects and summer has been busy for me. I am starting to circle back around now, thank you for you patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some enhancements to the ascii plotting:
It used to round to the smallest value a.k.a round up instead of down for negative values
Updating the plotting I wasn't really sure what
cfg[:offset]was meant to accomplish and couldn't really infer it from the examples, so that one might not do what it's supposed to do right now.