fix: add boolean string coercion for FastMCP tool parameters #1848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some LLM clients incorrectly serialize booleans as strings (
"false"instead offalsein JSON). This causes FastMCP tools to receivethe string
'false'instead of PythonFalse, makingif param:checks evaluate incorrectly.Root Cause
The existing
pre_parse_jsonmethod was supposed to handle this viajson.loads, but boolean values were being skipped because:json.loads("false")correctly returns PythonFalseboolis a subclass ofintin Pythonisinstance(pre_parsed, str | int | float)matches booleans (sinceisinstance(False, int)isTrue)Changes
pre_parse_jsonmethod"true"/"false"strings (any case) → PythonTrue/FalseboolTesting
Related Issues
Fixes #1843